Allow to receive datastore by name or by id #37
Closed
+74
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
force-pushed
the
accept_datastore_id_when_adding_disk
branch
3 times, most recently
from
bf96c5a
to
e154228
Compare
agrare
pushed a commit
to agrare/manageiq-providers-ovirt
that referenced
this pull request
May 16, 2017
…_fixed_ip_per_eni Fix collection of secordary fixed ip per eni
masayag
force-pushed
the
accept_datastore_id_when_adding_disk
branch
2 times, most recently
from
cff61a1
to
5763a16
Compare
|
This PR depends on ManageIQ/manageiq#15101 |
|
@borod108 this PR depends on ManageIQ/manageiq#15101 but could be review at the meanwhile. |
borod108
reviewed
May 18, 2017
| context "when storage exists" do | ||
| let(:storage) { FactoryGirl.create(:storage, :name => storage_name, :id => storage_id) } | ||
|
|
||
| it "searches for a storage by its ID" do |
There was a problem hiding this comment.
I would change the "searcher" to "finds" here and in the next examples because when I read this I thought you will have something like expect(Storage).to receive(:find)
masayag
force-pushed
the
accept_datastore_id_when_adding_disk
branch
from
5763a16
to
c00b78e
Compare
Datastores on the same setup may have the same name. In order to add a disk on a specific datastore, it is better to use the datastore id. https://bugzilla.redhat.com/show_bug.cgi?id=1450952 https://bugzilla.redhat.com/show_bug.cgi?id=1427498
masayag
force-pushed
the
accept_datastore_id_when_adding_disk
branch
from
c00b78e
to
a9c2c12
Compare
|
Checked commit masayag@a9c2c12 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datastores on the same setup may have the same name. In order to add a
disk on a specific datastore, it is better to use the datastore id.
https://bugzilla.redhat.com/show_bug.cgi?id=1450952
https://bugzilla.redhat.com/show_bug.cgi?id=1427498